-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
ERR: clarify PerformanceWarning for fragmented frame #42942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
lgtm ping on green |
doc/source/whatsnew/v1.3.2.rst
Outdated
@@ -45,6 +45,7 @@ Bug fixes | |||
Other | |||
~~~~~ | |||
- :meth:`pandas.read_parquet` now supports reading nullable dtypes with ``fastparquet`` versions above 0.7.1. | |||
- Clarified suggested fix for ``PerformanceWarning`` emitted with a highly fragmented :class:`DataFrame` (:issue:`42579`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the release note above this one is not yet on 1.3.x (not backported), so this may need a manual backport.
Alternatively, I think we don't normally add a release note when just a message is changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok sounds good, have just removed note then
thanks @mzeitlin11 |
@meeseeksdev backport 1.3.x |
Something went wrong ... Please have a look at my logs. |
…ame (#42958) Co-authored-by: Matthew Zeitlin <[email protected]>
xref some confusion in #42477. If this is thought an improvement, could target 1.3.2 since more users now see this error than in 1.2.x